Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captured hero Guard Posts now have flags #2099

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

AdamPlenty
Copy link
Contributor

Fixes #445

@AdamPlenty AdamPlenty marked this pull request as ready for review December 27, 2022 01:19
@Loobinex
Copy link
Member

We have a white-flag now too: https://github.com/dkfans/keeperfx/wiki/Adding-or-using-Custom-sprites#bundled-custom-sprites
Would it not be better to just add that and have it be consistent?

@walt253
Copy link
Contributor

walt253 commented Apr 29, 2023

We have a white-flag now too: https://github.com/dkfans/keeperfx/wiki/Adding-or-using-Custom-sprites#bundled-custom-sprites Would it not be better to just add that and have it be consistent?

Considering there is a limit for custom sprites it might be a good thing to implement this by default?

@Loobinex
Copy link
Member

@Watler253 I would love too, but I can't add default sprites yet.

@walt253 walt253 requested a review from Loobinex October 8, 2024 16:07
@Loobinex
Copy link
Member

Loobinex commented Oct 8, 2024

@walt253 there are several errors that would stop it from being build.

@walt253
Copy link
Contributor

walt253 commented Oct 8, 2024

@walt253 there are several errors that would stop it from being build.

I see, I triggered a review to see if it builds, apparently no.

Yes the roaming heroes can be multiple so there is no more hero_player_num and I believe create_guard_flag_object is removed since guard post flag uses spritecolors.toml now.

@walt253 walt253 marked this pull request as draft October 8, 2024 16:14
@Loobinex
Copy link
Member

Loobinex commented Nov 5, 2024

@walt253 want to continue with this, or shall we close it as stale?

@walt253
Copy link
Contributor

walt253 commented Nov 6, 2024

@walt253 want to continue with this, or shall we close it as stale?

No, I don't like working on someone else branch.

But what more is needed or what is not working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No flag on converted hero guardpost
3 participants